[Webkit-unassigned] [Bug 111258] PDFPlugin: Rename delegate method from openWithPreview to openWithNativeApplication

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=111258


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #191121|review?                     |review+
               Flag|                            |




--- Comment #2 from Alexey Proskuryakov <ap at webkit.org>  2013-03-02 18:28:33 PST ---
(From update of attachment 191121)
View in context: https://bugs.webkit.org/attachment.cgi?id=191121&action=review

r=me assuming there is a good answer to the question below.

> Source/WebKit2/ChangeLog:11
> +        Rename from openWithPreview to openWithNativeApplication for accuracy.

I don't understand this explanation. The delegate name should match what PDFLayerController expects, even if we find that inaccurate.

Did PDFLayerController change? If it did, do we need to support both names for the time being?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.