[Webkit-unassigned] [Bug 111126] Enable GPU-GPU texture copy in texImage2D() for HTMLVideoElement if hardware accelerated video decode is in use

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 1 11:05:00 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=111126





--- Comment #7 from Eric Carlson <eric.carlson at apple.com>  2013-03-01 11:07:23 PST ---
(From update of attachment 190881)
View in context: https://bugs.webkit.org/attachment.cgi?id=190881&action=review

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:4116
> +    if (!video || !video->videoWidth() || !video->videoHeight()) {
> +        synthesizeGLError(GraphicsContext3D::INVALID_VALUE, "texSubImage2D", "no video");
> +        return;
> +    }

Is this change required by this patch or is it just an opportunistic fix?

> Source/WebCore/platform/graphics/MediaPlayer.h:334
> +    bool isVideoFrameOfFormatNativeTexture();
> +    bool copyVideoFrameInTexture(GraphicsContext3D&, Platform3DObject texture, GC3Denum internalFormat, bool premultiplyAlpha, bool flipY);

Why does copyVideoFrameInTexture() take a format parameter but isVideoFrameOfFormatNativeTexture() does not?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list