[Webkit-unassigned] [Bug 111126] Enable GPU-GPU texture copy in texImage2D() for HTMLVideoElement if hardware accelerated video decode is in use

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 1 08:15:52 PST 2013


--- Comment #6 from Eric Carlson <eric.carlson at apple.com>  2013-03-01 08:18:15 PST ---
(From update of attachment 190881)
View in context: https://bugs.webkit.org/attachment.cgi?id=190881&action=review

> Source/WebCore/ChangeLog:8
> +        In texImage2D() for HTMLVideoElement in WebGL, it is possible to do a GPU-GPU texture copy instead of CPU readback and upload when hardware accelerated video decode is in use. Each platform needs to implement the interface isVideoFrameOfFormatNativeTexture() and copyVideoFrameInTexture() to make it truely work.

Nit: please wrap this very long line.

> Source/WebCore/ChangeLog:14
> +        (WebCore):

These useless entries can be removed.

> Source/WebCore/ChangeLog:15
> +        (WebCore::HTMLVideoElement::copyVideoFrameInTexture):

I think it is helpful to have per-method comments describing what changed.

> Source/WebCore/html/HTMLVideoElement.cpp:245
> +    player()->setVisible(true);
> +    return player()->isVideoFrameOfFormatNativeTexture();

It seems strange that the visibility may change as a side effect of asking this question.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list