[Webkit-unassigned] [Bug 89451] [WK2][X11] Fix build break when building webkit2 without plugin process.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89451





--- Comment #10 from Balazs Kelemen <kbalazs at webkit.org>  2013-03-01 04:59:46 PST ---
(From update of attachment 190923)
View in context: https://bugs.webkit.org/attachment.cgi?id=190923&action=review

> Source/WebKit2/Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:195
>  }
>  
>  bool NetscapePluginModule::scanPlugin(const String& pluginPath)
> +#else
> +bool NetscapePluginModule::scanPlugin(const String& pluginPath, RawPluginMetaData& metaData)
> +#endif
>  {
> +#if ENABLE(PLUGIN_PROCESS)
>      RawPluginMetaData metaData;
> -
> +#endif
>      {
>          // Don't allow the plugin to pollute the standard output.
>          StdoutDevNullRedirector stdOutRedirector;

Instead of using such ugly ifdefs, I would just factor out the code that you really need from here into a separate function and just call it when plugin process is disabled. Let's call it something like | queryPluginInfo(const String& pluginPath, RawPluginMetaData&) | which is just the block of stdOutRedirector from scanPlugin. It would look much better I think.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.