[Webkit-unassigned] [Bug 112531] Network Panel: .swf file is always presented as loading by XHR

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=112531





--- Comment #17 from pdeng6 <pan.deng at intel.com>  2013-03-31 23:21:20 PST ---
(In reply to comment #16)
> I also don't think that this is a layering violation. But the name should be "isXMLHttpRequest", not "isXMLHttpRequestClient".
> 
> However, the design mildly worries me. Inspector should ideally have a better abstraction, and not get to low level implementation details like ThreadableLoaderClient.

thanks for your comments :)
Ideally, Inspector should instrument in real client XMLHttpRequest.cpp for detailed information for this, however, pre-flight is transparent, never pass through ThreadableClient.
I'm thinking another solution may be, add a virtual method didReceivePreflightResponse to ThreadableLoaderClient, default do nothing, and private override it in XMLHttpRequest, InspectorInstrumentation will be there.
Although only inspector works in the override function, XMLhttpRequest's client won't aware it as it's private.
your comments?

thanks
Pan

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.