[Webkit-unassigned] [Bug 113665] New: Make includes of types.h and time.h more consistent

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=113665

           Summary: Make includes of types.h and time.h more consistent
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: WebKit Gtk
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: eric at yorba.org


(Note: I'm not entirely sure where to file this one; I'm putting it under WebKitGTK since I'm building WebKitGTK 1.8.3, but feel free to change the component if there's a better fit.)

The strategy for including time.h and types.h seems inconsistent.  For example, in JavaScriptCore/jsc.cpp time.h is included like this:

> #if HAVE(SYS_TIME_H)
> #include <sys/time.h>
> #endif

As far as I'm aware, that's the most platform-independent way to include time.h because the build script sets SYS_TIME_H correctly.  But on the other hand, look at WebCore/page/page.h:

> #if OS(SOLARIS)
> #include <sys/time.h> // For time_t structure.
> #endif

This isn't the right way to go; someone probably added that #if because they wanted it to work on Solaris, without realizing other platforms could be affected as well.

The usage of types.h has similar issues, although it doesn't appear the build scripts are setting a #define for types.h.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.