[Webkit-unassigned] [Bug 113637] [EFL] Get rid of --tiled-backing-store flag. Create and use --accelerated-composition instead.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=113637





--- Comment #1 from Ed Bartosh <bartosh at gmail.com>  2013-03-30 02:36:11 PST ---
As far as I can see from the EwkView.cpp code(see below) EvasGLContext::create is not called when accelerated composition is off. It was fixed in my previous patch https://bug-113627-attachments.webkit.org/attachment.cgi?id=195820

Have I understood correctly that this is enough to get rid of --tiled-backing-store flag and introduce new flag --accelerated-compositing?

> git blame --date=short -L'278,289' WebKit2/UIProcess/API/efl/EwkView.cpp 
95177455 (mikhail.pozdnyakov at intel.com 2013-03-19 278)     webView()-a>setEwkView(this);
02c57c8c (Ed Bartosh                   2013-03-30 279) #if USE(ACCELERATED_COMPOSITING)
61a77905 (kenneth at webkit.org           2013-02-13 280)     m_evasGL = adoptPtr(evas_gl_new(evas_object_evas_get(m_evasObject)));
61a77905 (kenneth at webkit.org           2013-02-13 281)     if (m_evasGL)
61a77905 (kenneth at webkit.org           2013-02-13 282)         m_evasGLContext = EvasGLContext::create(m_evasGL.get());
61a77905 (kenneth at webkit.org           2013-02-13 283) 
61a77905 (kenneth at webkit.org           2013-02-13 284)     if (!m_evasGLContext) {
61a77905 (kenneth at webkit.org           2013-02-13 285)         WARN("Failed to create Evas_GL, falling back to software mode.");
61a77905 (kenneth at webkit.org           2013-02-13 286)         m_isAccelerated = false;
61a77905 (kenneth at webkit.org           2013-02-13 287)     }
02c57c8c (Ed Bartosh                   2013-03-30 288) #endif
8d826648 (kenneth at webkit.org           2013-02-05 289)     WKViewInitialize(wkView());

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.