[Webkit-unassigned] [Bug 113331] Web Inspector: Encapsulate SetEmbedderData/GetEmbedderData

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=113331


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #195137|review?                     |review-
               Flag|                            |




--- Comment #2 from Pavel Feldman <pfeldman at chromium.org>  2013-03-30 02:11:45 PST ---
(From update of attachment 195137)
View in context: https://bugs.webkit.org/attachment.cgi?id=195137&action=review

> Source/WebCore/bindings/v8/V8PerContextData.cpp:175
> +            wanted = snprintf(buffer, sizeof(buffer), "%s", worldName);

So you formatted the format above, but you don't actually need it here? Why formatting the format at all then? I.e. 
if (debugId == -1)
    snprintf(buffer, sizeof(buffer), "%s", worldName);
else
    snprintf(buffer, sizeof(buffer), "%s,%d", worldName, debugId);

sounds simpler.

> Source/WebCore/bindings/v8/V8PerContextData.cpp:185
> +v8::Handle<v8::Value> V8PerContextDebugData::getDebugData(v8::Handle<v8::Context> context)

No get prefixes in WebKit, simply debugData()

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.