[Webkit-unassigned] [Bug 34085] [GTK] Should use GStreamer codec installation infrastructure

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34085


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #195748|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #10 from Martin Robinson <mrobinson at webkit.org>  2013-03-29 08:17:35 PST ---
(From update of attachment 195748)
View in context: https://bugs.webkit.org/attachment.cgi?id=195748&action=review

Very simple and nice! Please fix the style issues when landing.

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:50
> +#include <gst/pbutils/missing-plugins.h>

Should be listed alphabetically in the list.

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:782
> +            GstInstallPluginsReturn result = gst_install_plugins_async(&detail, 0, mediaPlayerPrivatePluginInstallerResultFunction, reinterpret_cast<gpointer>(this));

There's no cast necessary to go from a class pointer to void* and reinterpret_cast here can hide real errors, so please remove the cast.

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:35
> +#include <gst/pbutils/install-plugins.h>

Please list this alphabetically.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.