[Webkit-unassigned] [Bug 113568] g_slist_reverse() may not be required in webKitWebAudioSrcLoop

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 29 06:47:23 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=113568





--- Comment #2 from Philippe Normand <pnormand at igalia.com>  2013-03-29 06:45:33 PST ---
(From update of attachment 195722)
View in context: https://bugs.webkit.org/attachment.cgi?id=195722&action=review

Looks good but I'd like to test this patch before landing

> Source/WebCore/ChangeLog:8
> +        Decremental for loop logic implemented to avoid using g_slist_reverse().

This could be expanded a bit, explaining the performance gain.

> Source/WebCore/ChangeLog:10
> +        No new tests (OOPS!).

You'd need to remove this line unless you state the patch is covered by existing webaudio tests.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list