[Webkit-unassigned] [Bug 113522] [qt] Enable WebVTT text tracks and inband text tracks from GStreamer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=113522


Brendan Long <b.long at cablelabs.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Gtk, HTML5, Qt
          Component|New Bugs                    |WebKit Qt




--- Comment #2 from Brendan Long <b.long at cablelabs.com>  2013-03-28 11:37:11 PST ---
See:

https://bugreports.qt-project.org/browse/QTBUG-29613

Sorry about the large number of changes. I was planning to separate them into four patches but the webkit-patch tool doesn't seem to like that. I can break this into multiple patches or bug reports if it would be easier to review.

This patch:

  * Enables text tracks in QtWebKit (setting VIDEO_ENABLED=1, adding the TextTrack* files to the build, adding some strings).
  * Add support for inband text tracks to ports that use GStreamer (if VIDEO_ENABLED=1).
  * Fixes some bugs in text track handling (checking cues without a null check, displaying disabled cues)
  * Changes two of the layout tests to use counting-subtitled.ogv/mov instead of counting-captioned.mov.

The change to the layout tests seems possibly controversial, since it changes the original tests and doesn't use the established standard (findMediaFile). The reason I had to do this is that GStreamer can't handle any kind of captions that I can tell, so I can't make the kind == captions part work, and as far as I can tell, GStreamer doesn't support any subtitle formats that can be held in a mp4 or mov container. My solution is to add two <source>s, with the .ogv first, on the assumption that since Safari doesn't support .ogv, this shouldn't cause any problems for them.

These changes caused two previously failing layout tests to pass. Is there somewhere that I should change to make a note of that?

Since the GStreamer changes don't just effect Qt, I'd like to get someone from WebKitGTK on this as well.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.