[Webkit-unassigned] [Bug 113454] GCC 4.8 error - C++ nested class inheriting enclosing class

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=113454





--- Comment #5 from Benjamin Poulain <benjamin at webkit.org>  2013-03-28 10:42:34 PST ---
(From update of attachment 195591)
View in context: https://bugs.webkit.org/attachment.cgi?id=195591&action=review

> Source/WTF/ChangeLog:9
> +
> +        * wtf/HashMap.h:
> +        (HashMap):

Here you should include a short description of your change.
You need to say what you fix (or why do you make the change), and how you fix it. (here is an example: http://trac.webkit.org/changeset/146372/trunk/Source/WTF/ChangeLog).

This description is intended for people reading your code in the future (typically a few years from now with WTF). It explains why a certain change was made.

> Source/WTF/wtf/HashMap.h:143
> +    template<typename KeyArg, typename MappedArg, typename HashArg = typename DefaultHash<KeyArg>::Hash,
> +        typename KeyTraitsArg = HashTraits<KeyArg>, typename MappedTraitsArg = HashTraits<MappedArg> >

It looks from the bot that passing default template arguments is not correct here.

> Source/WTF/wtf/HashMap.h:186
> +            typedef HashMap<KeyArg, MappedArg, HashArg, KeyTraitsArg, MappedTraitsArg> HashMapInst;

HashMapInst -> HashMapType.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.