[Webkit-unassigned] [Bug 113357] Web Inspector: gather accessor property getter and setter under a single tree node

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=113357


Yury Semikhatsky <yurys at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #195447|review?                     |review+
               Flag|                            |




--- Comment #17 from Yury Semikhatsky <yurys at chromium.org>  2013-03-28 07:13:18 PST ---
(From update of attachment 195447)
View in context: https://bugs.webkit.org/attachment.cgi?id=195447&action=review

Please attach screenshot.

> Source/WebCore/inspector/front-end/ObjectPropertiesSection.js:481
> +        if (properties[i].value == null)

== -> ===

> Source/WebCore/inspector/front-end/RemoteObject.js:218
>                  if (property.get || property.set) {

style: no {} around one liners
I'd rather move this get/set logic into constructor.

> Source/WebCore/inspector/front-end/RemoteObject.js:453
> +    if (descriptor && descriptor.get) {

style: no {} around one liners

> Source/WebCore/inspector/front-end/RemoteObject.js:456
> +    if (descriptor && descriptor.set) {

style: no {} around one liners

> LayoutTests/inspector/debugger/properties-special.html:71
> +                if (children[j].nameElement && children[j].nameElement.textContent === "__proto__") {

style: no {} around one liners

> LayoutTests/inspector/runtime/runtime-getProperties.html:63
> +    function convertPropertyValueForTest(propertyObj, fieldName)

propertyObj -> propertyObject

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.