[Webkit-unassigned] [Bug 113239] Web Inspector: REGRESSION: Standalone image documents fail to return resource content
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Mar 28 04:45:35 PDT 2013
https://bugs.webkit.org/show_bug.cgi?id=113239
Pavel Feldman <pfeldman at chromium.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #195530|review? |review-
Flag| |
--- Comment #5 from Pavel Feldman <pfeldman at chromium.org> 2013-03-28 04:43:45 PST ---
(From update of attachment 195530)
View in context: https://bugs.webkit.org/attachment.cgi?id=195530&action=review
> Source/WebCore/inspector/InspectorPageAgent.cpp:324
> + // Since MainResource may be actual image resource, use mime type to determine the type for Inspector's view
This comment does not add much, consider removing.
> Source/WebCore/inspector/InspectorPageAgent.cpp:326
> + return MIMETypeRegistry::isSupportedImageMIMEType(cachedResource.response().mimeType()) ? InspectorPageAgent::ImageResource : InspectorPageAgent::DocumentResource;
Why not to check cached resource's type instead?
> Source/WebCore/inspector/InspectorResourceAgent.cpp:273
> + else if (equalIgnoringFragmentIdentifier(response.url(), loader->url()) && !loader->isCommitted() && type == InspectorPageAgent::OtherResource)
Why would other result in document?
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list