[Webkit-unassigned] [Bug 113482] New: [webkitpy] infinite loop in _test_patch() retries

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=113482

           Summary: [webkitpy] infinite loop in _test_patch() retries
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: glenn at skynav.com


In webkitpy.tool.bot.patchanalysistask.PatchAnalysisTask._test_patch(), there appear two cases where False is returned which can lead to an infinite retry loop:

(1) when second_results fail a different set of tests than first_results
(2) when the method falls through to the final return False without invoking report_failure()

When False is always returned from this method, the EWS queue will continue to retry testing the patch without stopping unless the patch is obsoleted or r- is marked.

I observed this happening today at http://queues.webkit.org/patch/195207, where 24 attempts were made to retry _test_patch() before I marked the patch as r- and then obsoleted the patch (just to make sure it would fail validation).

The EarlyWarningSystemTask should be modified ensure that some limit is applied to the number of retry attempts.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.