[Webkit-unassigned] [Bug 113446] cache parsed interfaces in CodeGenerator.pm

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=113446





--- Comment #2 from arno. <arno at renevier.net>  2013-03-27 15:31:49 PST ---
Created an attachment (id=195414)
 --> (https://bugs.webkit.org/attachment.cgi?id=195414&action=review)
script used to benchmark binding generations

(In reply to comment #1)
> Sounds reasonable.
> 
> Did you observe any performance issue caused by the redundant parsing? (I'm just curious about it because parent chains wouldn't be long in most cases.)


I definitively see an improvement by caching the results.
I used the attached script, launched from WebKitBuild/Release/ to benchmark generate-bindings.pl

When running it on all the WebCore idls, it take me 
3'40" for JavascriptCore and about 13' for V8
With caching, it takes me about 2'10" for both.

(I ran the tests several times to avoid cold cache bias)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.