[Webkit-unassigned] [Bug 113364] Selection code spends a lot of time in InlineTextBox::localSelectionRect
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 27 10:38:44 PDT 2013
https://bugs.webkit.org/show_bug.cgi?id=113364
Enrica Casucci <enrica at apple.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #195214| |review-
Flag| |
--- Comment #5 from Enrica Casucci <enrica at apple.com> 2013-03-27 10:36:54 PST ---
(From update of attachment 195214)
View in context: https://bugs.webkit.org/attachment.cgi?id=195214&action=review
Missing ChangeLog file
>> Source/WebCore/rendering/InlineTextBox.cpp:211
>> + if (sPos != 0 || ePos != static_cast<int>(m_len))
>
> Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
Please fix the style issue and add a comment.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list