[Webkit-unassigned] [Bug 113260] Add a runtime flag in WebRuntimeFeatures to enable 'image/webp' accept header

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 27 02:51:08 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=113260





--- Comment #8 from Mike West <mkwst at chromium.org>  2013-03-27 02:53:34 PST ---
(From update of attachment 195009)
View in context: https://bugs.webkit.org/attachment.cgi?id=195009&action=review

Two drive-by comments:

> Source/WebCore/loader/cache/CachedImage.h:102
> +    void setCustomAccept(); // Helper method to set the Accept header.

Would you mind renaming this to something that makes it clear that we're setting the header? I think 'CachedImage::setCustomAcceptHeader' would be clear enough that you could remove the comment.

> Source/WebKit/chromium/src/WebRuntimeFeatures.cpp:765
> +    UNUSED_PARAM(enable);

Copy/paste error: There's no 'enable' in this method.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list