[Webkit-unassigned] [Bug 107539] [ca] Tell CA to clean up unused resources if a given WebProcess won't be drawing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=107539


Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #194960|review?                     |review+
               Flag|                            |




--- Comment #6 from Simon Fraser (smfr) <simon.fraser at apple.com>  2013-03-26 16:30:53 PST ---
(From update of attachment 194960)
View in context: https://bugs.webkit.org/attachment.cgi?id=194960&action=review

> Source/WebCore/platform/mac/WebCoreSystemInterface.mm:195
> +void(*wkCABackingStoreCollectBlocking)(void);

I think we should change this name to something less mysterious.

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:373
> +    if (!parameters.isInWindow) {
> +        // Page defaults to on-screen, but setIsInWindow depends on it being a valid indicator of actually having been put into a window.
> +        m_page->setCanStartMedia(false);
> +        m_page->willMoveOffscreen();
> +    }

Is this behavior change detectable at all? Will it break anything?

> Source/WebKit2/WebProcess/WebProcess.cpp:1078
> +    m_inWindowPageCount--;

I think you should assert that m_inWindowPageCount is > 0 here. Consider making it signed for slightly less bad behavior if miscounting occurs in a release build.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.