[Webkit-unassigned] [Bug 113349] New: Bug 110293 uses read -d which is a non-portable bashism

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=113349

           Summary: Bug 110293 uses read -d which is a non-portable
                    bashism
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Other
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: WebKit Gtk
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: landry at openbsd.org
                CC: mrobinson at webkit.org


Webkitgtk 1.11.92 fails to configure, see bug 110293 comment 6 :

read -d '' DEFAULT_FEATURE_DEFINES <<"EOF"
   ENABLE_ACCELERATED_2D_CANVAS=0
   ENABLE_BATTERY_STATUS=0
...
   ENABLE_XHR_TIMEOUT=1
EOF

read -d is a bashism, which fails where sh!=bash - ksh, in our case.

read DEFAULT_FEATURES_DEFINES << "EOF"
   ENABLE_ACCELERATED_2D_CANVAS=0 \
   ENABLE_BATTERY_STATUS=0 \
...
   ENABLE_XHR_TIMEOUT=1
EOF

works here, and is portable.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.