[Webkit-unassigned] [Bug 113268] New: Cleanup Image::hasImage() (and related hasImage functions)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=113268

           Summary: Cleanup Image::hasImage() (and related hasImage
                    functions)
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Images
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: pdr at google.com


RenderImageResource::hasImage() returns whether the image resource has a cached image. CachedImage::hasImage() returns whether a cached image has an image.

Various codepaths do various checks. Here are two examples:

http://trac.webkit.org/browser/trunk/Source/WebCore/rendering/RenderImage.cpp?rev=146279#L378
RenderImage checks hasImage(), then checks if the image is null.

http://trac.webkit.org/browser/trunk/Source/WebCore/rendering/svg/RenderSVGImage.cpp#L118
RenderSVGImage checks hasImage() but does not check for null or nullimage, and will pass a null image to context->drawImage()

This isn't easy to understand; we should clean this up.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.