[Webkit-unassigned] [Bug 113168] LayoutTests/fast/js/large-expressions.html crashes on Linux

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=113168


Geoffrey Garen <ggaren at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #194783|review?                     |review-
               Flag|                            |




--- Comment #9 from Geoffrey Garen <ggaren at apple.com>  2013-03-25 17:24:07 PST ---
(From update of attachment 194783)
View in context: https://bugs.webkit.org/attachment.cgi?id=194783&action=review

> Source/WTF/wtf/StackBounds.cpp:149
> +    // no matter in glibc or bionic(android's libc) implementation,

Let's change this comment to: "glibc and bionic (Android's libc) use the guard size API to set a guard page at the stack base."

> Source/WTF/wtf/StackBounds.cpp:154
> +    int rc = pthread_attr_getguardsize(&sattr, &guardSize);

pthread_attr_getguardsize is standard POSIX, so I think we should do this on all platforms.

> Source/WTF/wtf/StackBounds.cpp:155
> +    stackBase = reinterpret_cast<void *>(reinterpret_cast<unsigned long>(stackBase) + guardSize);

"void*" instead of "void *", please.

Also, to cast a pointer to integer, use uintptr_t.

Also, you need to round guardSize up to the system page size.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.