[Webkit-unassigned] [Bug 109884] Add CSS Property tracking to FeatureObserver. Creates new histogram for CSS Property usage data.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=109884





--- Comment #24 from Kassy Coan <kassycoan at gmail.com>  2013-03-25 17:04:23 PST ---
(In reply to comment #22)

> > Source/WebCore/page/FeatureObserver.cpp:41
> > +static int mapCSSPropertyId(int id)
> > +{
> > +    switch (id) {
> 
> I'm not a huge fan of adding another switch statement that we need to update every time we add/remove a CSS property. The switch statement is fine, but lets only put the properties in this switch statement that we actually care to measure. Specifically, lets just put the WebKit prefixed properties for now since those are the properties we'd like to kill if they have sufficiently low usage.

I believe we do care to measure all the properties. We would like to compare the usage of the prefixed versions to the non prefixed versions.

> 
> > Source/WebCore/page/FeatureObserver.cpp:529
> > +    if (flushCSSResults)
> > +        HistogramSupport::histogramEnumeration("WebCore.FeatureObserver.CSSProperties", cssFlushPropertyId(), maximumCSSPropertyId());
> 
> I don't really follow what the flushing is all about. Can you add a description of this to the ChangeLog?

Done.

> 
> > Source/WebCore/page/FeatureObserver.h:137
> > +    BitVector m_CSSFeatureBits;
> 
> Should this also be OwnPtr like m_featureBits? Then you also can initialize it lazily.

This was previously an OwnPtr and dynamically allocated, but changed as per request of Tony Chang.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.