[Webkit-unassigned] [Bug 113215] New: Convert WebInputEvent::GestureDoubleTap to PlatformEvent::NoType

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=113215

           Summary: Convert WebInputEvent::GestureDoubleTap to
                    PlatformEvent::NoType
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Event Handling
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: miletus at chromium.org
                CC: mnaganov at chromium.org, rbyers at chromium.org


In bug 93045 we removed PlatformEvent::GestureDoubleTap since now DoubleTap gesture
is implemented as a Tap gesture with tap_count = 2.

But in WebViewImpl::handleGestureEvent(), a PlatformEvent is built from the WebGestureEvent
regardless, even though the PlatfromEvent will never reach the WebCore. (DoubleTap in
our case, it is only handled in WebViewImpl for doube-tap-to-zoom).

And WebInpuEventConversion.cpp::PlatformGestureEventBuilder() will reach ASSERT_NOT_REACHED()
when WebInputEvent::GestureDoubleTap is passed in.

So the cleanest solution to me is to convert the WebGestureEvent::DoubleTap to a
PlatformEvent::NoType, this makes the conversion list from WebInputEvent to PlatformEvent
complete and we don't need a special handling for the DoubleTap event in WebViewImpl::handleGestureEvent()

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.