[Webkit-unassigned] [Bug 113036] New: E: webkitgtk3 missing-sentinel Source/[...]/TestMain.cpp:47

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=113036

           Summary: E: webkitgtk3 missing-sentinel
                    Source/[...]/TestMain.cpp:47
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: WebKit2
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: dimstar at opensuse.org


the open Build Service cancels the build of webkitgtk 1.11.92 (raising known compiler errors causing larger issues or security issues) with:

E: webkitgtk3 missing-sentinel Source/WebKit2/UIProcess/API/gtk/tests/TestMain.cpp:47

The compiler output for this build-root check was:

[24320s] Source/WebKit2/UIProcess/API/gtk/tests/TestMain.cpp: In function 'void removeNonEmptyDirectory(const char*)':
[24320s] Source/WebKit2/UIProcess/API/gtk/tests/TestMain.cpp:47:75: warning: missing sentinel in function call [-Wformat]

The code in question is:

        GOwnPtr<char> filePath(g_build_filename(directoryPath, fileName, 0)); 

=> (int) 0 is not to be used as sentinel in this case, but NULL should be the sentinel
(see also https://developer.gnome.org/glib/2.34/glib-Miscellaneous-Utility-Functions.html#g-build-filename :
gchar *             g_build_filename                    (const gchar *first_element,
                                                         ...);
... :    remaining elements in path, terminated by NULL


The commit introducing this warning into webkitgtk was:
http://trac.webkit.org/changeset/145528

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.