[Webkit-unassigned] [Bug 111513] Create a script to import W3C tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=111513





--- Comment #17 from Dirk Pranke <dpranke at chromium.org>  2013-03-21 18:33:34 PST ---
(From update of attachment 194324)
View in context: https://bugs.webkit.org/attachment.cgi?id=194324&action=review

This is a *lot* closer to webkitpy style ... thank you! I've only done a cursory pass over this so far, so here's some minor stylistic nits. I wouldn't bother making the changes yet until I can do a substantive review, but it looks like you're on the right path.

> Tools/ChangeLog:5
> +        You must have checked log the W3C repository to your local drive.

You largely appear to repeat the same text down in test_importer.py, so I'd just refer to that instead of copying it here.

nit: "checked out", not "checked log" :)

> Tools/ChangeLog:39
> +        - All files are converted to work in WebKit:

I think (as I suspect you do also) we will all be happier down the road the closer we can get to the "conversion" process being a no-op. Perhaps we should file separate bugs to track each issue we find as they come up. Here's a few comments in the meantime ...

> Tools/ChangeLog:40
> +            1. .xht extensions are changed to .xhtml to make new-run-webkit-tests happy

we should probably just make new-run-webkit-tests recognize .xht .

> Tools/ChangeLog:46
> +               new-run-webkit-tests expects

do we have any guesses as to how many extra copies of tests this creates? It might be more reasonable to insert shim -expected.html files that do redirects or iframe the actual references. This would probably require some buy-in from webkit-dev, so copies are good for now.

> Tools/ChangeLog:64
> +        Reviewed by NOBODY (OOPS!).

lines 61-64 should be at the top of the changelog, right under your name.

> Tools/Scripts/webkitpy/w3c/test_converter.py:3
> +# Copyright (C) 2010 Apple Inc. All rights reserved.

Presumably this should be (c) 2013 Adobe ...

> Tools/Scripts/webkitpy/w3c/test_converter.py:25
> +from webkitpy.thirdparty.BeautifulSoup import BeautifulSoup as Parser

why "as Parser" ?

> Tools/Scripts/webkitpy/w3c/test_importer.py:26
> +############################################################################################################

this should be a docstring rather than a comment. If you do that, then 'pydoc webkitpy.w3c.test_importer' will print this automatically :).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.