[Webkit-unassigned] [Bug 110375] Add client callbacks to notify of changes of associated form controls

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=110375


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #194347|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #96 from Ryosuke Niwa <rniwa at webkit.org>  2013-03-21 16:37:28 PST ---
(From update of attachment 194347)
View in context: https://bugs.webkit.org/attachment.cgi?id=194347&action=review

> Source/WebKit/chromium/src/ChromeClientImpl.cpp:1148
> +void ChromeClientImpl::didAssociateFormControls(Vector<Element*>& elements)

This should certainly be const Vector<Element*>&. cq- because of this.

> Source/WebKit/chromium/src/ChromeClientImpl.cpp:1156
> +    Vector<Element*>::iterator end = elements.end();
> +    for (Vector<Element*>::iterator it = elements.begin(); it != end; ++it, ++i)
> +        elementVector[i] = WebNode(*it);

We prefer indexing over iterators for vectors.
See http://www.webkit.org/coding/coding-style.html#punctuation

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.