[Webkit-unassigned] [Bug 112886] [SH4] LLInt sh4 backend implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=112886





--- Comment #4 from Julien Brianceau <jbrianceau at nds.com>  2013-03-21 01:51:54 PST ---
(In reply to comment #3)
> This looks OK, but one fairly major high-level comment: why aren't you using the risc.rb transformations?  You seem to be rolling a lot of address operand lowering yourself.  risc.rb can do it for you, and can probably do a better job, and generate better code.
>
> I mean, it's not my business to tell you to make SH4 run faster.  But I figured I'd point out that there is a better way to do this.
I'm sure there is a better way to do this.. I didn't know anything to ruby before writing this patch :) I'm going to take a deeper look at risc.rb and see what can be reused for the sh4 backend.

> 
> Other than that, please fix the two cases of unnecessary code duplication.  I can r+ once you do.
Sure.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.