[Webkit-unassigned] [Bug 112886] [SH4] LLInt sh4 backend implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=112886


Filip Pizlo <fpizlo at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #194199|review?                     |review-
               Flag|                            |




--- Comment #3 from Filip Pizlo <fpizlo at apple.com>  2013-03-21 01:22:09 PST ---
(From update of attachment 194199)
View in context: https://bugs.webkit.org/attachment.cgi?id=194199&action=review

This looks OK, but one fairly major high-level comment: why aren't you using the risc.rb transformations?  You seem to be rolling a lot of address operand lowering yourself.  risc.rb can do it for you, and can probably do a better job, and generate better code.

I mean, it's not my business to tell you to make SH4 run faster.  But I figured I'd point out that there is a better way to do this.

Other than that, please fix the two cases of unnecessary code duplication.  I can r+ once you do.  But I would kind of like to see this done in terms of risc.rb unless there is a strong reason not to.

> Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:120
> +    elsif SH4

You could just have said "elsif MIPS or SH4" above

> Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:151
> +    elsif SH4

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.