[Webkit-unassigned] [Bug 112710] Web Inspector: Remove remainings of CSS-based console message filtering.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=112710


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #193998|review?                     |review-
               Flag|                            |




--- Comment #9 from Pavel Feldman <pfeldman at chromium.org>  2013-03-20 23:14:31 PST ---
(From update of attachment 193998)
View in context: https://bugs.webkit.org/attachment.cgi?id=193998&action=review

> Source/WebCore/inspector/front-end/ConsoleView.js:-274
> -            if (target.hasStyleClass("selected")) {

Why did this change?

> Source/WebCore/inspector/front-end/ConsoleView.js:-288
> -        if (!selectMultiple) {

This seems to ruin the diff. Can you leave existing condition nesting?

> Source/WebCore/inspector/front-end/ConsoleView.js:539
> +        return (!message.url || !this._messageURLFilters[message.url]) && (!message.level || this._messageLevelFilters.indexOf(message.level) != -1);

This might get a bit expensive - consider using an object for faster lookup.

> Source/WebCore/inspector/front-end/ConsoleView.js:774
> + * @param wasThrown

You should specify types for parameters and list them in proper order.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.