[Webkit-unassigned] [Bug 112857] New: AXObjectCache::postNotification should use an enum instead of a bool
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 20 16:47:04 PDT 2013
https://bugs.webkit.org/show_bug.cgi?id=112857
Summary: AXObjectCache::postNotification should use an enum
instead of a bool
Product: WebKit
Version: 528+ (Nightly build)
Platform: Unspecified
OS/Version: Unspecified
Status: NEW
Severity: Normal
Priority: P2
Component: Accessibility
AssignedTo: webkit-unassigned at lists.webkit.org
ReportedBy: eric at webkit.org
CC: dmazzoni at google.com, aboxhall at chromium.org
AXObjectCache::postNotification should use an enum instead of a bool (since it's a multi-argument function)
I'm slowly trying to rid WebKit of this pattern, as it leads to very difficult to understand callsites:
axObjectCache()->postNotification(node(), AXObjectCache::AXValueChanged, true);
At least:
axObjectCache()->postNotification(node(), AXObjectCache::AXValueChanged, PostToElement);
would be clearer. Although it's not yet clear to me what the "postToElement" bool is supposed to do. :)
Once I figure out what postToElement means, I can come up with nice names for a replacement enum. Any suggestions would be most welcome. :)
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list