[Webkit-unassigned] [Bug 112418] FrameLoaderClient::assignIdentifierToInitialRequest() not called for the main resource when loaded from the memory cache

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 20 09:18:08 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=112418





--- Comment #15 from Nate Chapin <japhet at chromium.org>  2013-03-20 09:20:35 PST ---
8(In reply to comment #14)
> (From update of attachment 193463 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=193463&action=review
> 
> >> Source/WebCore/loader/MainResourceLoader.cpp:444
> >> +    }
> > 
> > Would it be better to fix this by moving the addResponse() call in ResourceLoadNotifier to dispatchDidReceiveResponse() from didReceiveResponse()?
> 
> hmm, this is the only case where we are using dispatchDidReceiveResponse() directly, so it would work, but in ResourceLoadNotifier dispatchDidReceiveResponse() is also called from sendRemainingDelegateMessages(), do we want to add the response in that case too?

I would guess that we do, but I'm not absolutely sure.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list