[Webkit-unassigned] [Bug 111889] Web Inspector: Error handling for ScriptPreprocessor

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=111889





--- Comment #14 from johnjbarton <johnjbarton at chromium.org>  2013-03-20 07:35:08 PST ---
(In reply to comment #13)
> (From update of attachment 193950 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=193950&action=review
> 
> > Source/WebCore/bindings/v8/ScriptDebugServer.cpp:109
> > +        if (tryCatch.HasCaught()) {
> 
> Did you try calling SetVerbose on the handler instead of all of this code?

Setting tryCatch.setVerbose(true) triggers WebKit/Source/WebCore/bindings/v8/V8Initializer messageHandlerInMainThread, a message listener on v8::V8.  The messageHandlerInMainThread() only works if called on a context related to the main thread window. The preprocessor however is in a utility context and has no 'window' so messageHandlerInMainThread() crashes.  Since this handler is hard wired into the thread, there is no practical way to replace it. 

> 
> > Source/WebCore/bindings/v8/ScriptDebugServer.cpp:123
> > +            exceptionTarget->document()->reportException("preprocessor script must evaluate to a function", 0, "", 0);
> 
> Please do not reach for the console via document - there is now PageConsole accessible from page. You might need to be Page-aware (PageScriptDebugServer)

I don't understand what you mean by Page-aware or Page for that matter. But I can remove the path though document().

> 
> > Source/WebCore/bindings/v8/V8Binding.cpp:88
> > +    String exceptionMessage = toWebCoreStringWithUndefinedOrNullCheck(message->Get());
> 
> I don't think we need another method of a kind. Certainly not here.

Sorry I don't understand "method of a kind"? To be sure, I don't know which conversion from Message to String is appropriate here, I just used one that was already used in the file. What should I use instead?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.