[Webkit-unassigned] [Bug 111889] Web Inspector: Error handling for ScriptPreprocessor

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=111889


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #193950|review?                     |review-
               Flag|                            |




--- Comment #13 from Pavel Feldman <pfeldman at chromium.org>  2013-03-20 00:58:37 PST ---
(From update of attachment 193950)
View in context: https://bugs.webkit.org/attachment.cgi?id=193950&action=review

> Source/WebCore/bindings/v8/ScriptDebugServer.cpp:109
> +        if (tryCatch.HasCaught()) {

Did you try calling SetVerbose on the handler instead of all of this code?

> Source/WebCore/bindings/v8/ScriptDebugServer.cpp:123
> +            exceptionTarget->document()->reportException("preprocessor script must evaluate to a function", 0, "", 0);

Please do not reach for the console via document - there is now PageConsole accessible from page. You might need to be Page-aware (PageScriptDebugServer)

> Source/WebCore/bindings/v8/V8Binding.cpp:88
> +    String exceptionMessage = toWebCoreStringWithUndefinedOrNullCheck(message->Get());

I don't think we need another method of a kind. Certainly not here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.