[Webkit-unassigned] [Bug 112676] REGRESSION(r146089): It broke 20 sputnik tests on ARM traditional and Thumb2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=112676





--- Comment #12 from Filip Pizlo <fpizlo at apple.com>  2013-03-19 16:19:39 PST ---
(In reply to comment #11)
> (In reply to comment #7)
> > Also, is ARMv7 on Qt using the ARMv7Assembler?
> 
> Our GCC's default is ARM, which uses ARMAssembler, but we can 
> override it with -mthumb cflag and then ARMv7Assembler is used.
> I checked manually and this bug is valid with both of them.

OK - this is super weird!

This test passes fine for me.

I think I found the issue though.  Look at this code in DFGSpeculativeJIT.h:

    JITCompiler::Call callOperation(C_DFGOperation_EJ operation, GPRReg result, GPRReg arg1Tag, GPRReg arg1Payload)
    {
        m_jit.setupArgumentsWithExecState(arg1Payload, arg1Tag);
        return appendCallWithExceptionCheckSetResult(operation, result);
    }

Can you try passing EABI_32BIT_DUMMY_ARG like so:

        m_jit.setupArgumentsWithExecState(EABI_32BIT_DUMMY_ARG arg1Payload, arg1Tag);

And seeing if it passes?  The DUMMY_ARG thing isn't necessary on our ABI but I think it is on yours.

Sorry for this breakage!  ABIs are hard! ;-)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.