[Webkit-unassigned] [Bug 98358] [GTK] accessibility/aria-scrollbar-role.html is failing
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 18 08:05:48 PDT 2013
https://bugs.webkit.org/show_bug.cgi?id=98358
Martin Robinson <mrobinson at webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #193565|review? |review-
Flag| |
--- Comment #2 from Martin Robinson <mrobinson at webkit.org> 2013-03-18 08:08:02 PST ---
(From update of attachment 193565)
View in context: https://bugs.webkit.org/attachment.cgi?id=193565&action=review
Some unnecessary string duplication going on, but otherwise looks good to me. :)
> Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:514
> + GOwnPtr<gchar> axOrientation;
> + if (checkElementState(m_element, ATK_STATE_HORIZONTAL))
> + axOrientation.set(g_strdup_printf("AXOrientation: AXHorizontalOrientation"));
> + else if (checkElementState(m_element, ATK_STATE_VERTICAL))
> + axOrientation.set(g_strdup_printf("AXOrientation: AXVerticalOrientation"));
> +
> + if (!axOrientation)
> + return JSStringCreateWithCharacters(0, 0);
> +
> + return JSStringCreateWithUTF8CString(axOrientation.get());
See below.
> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:552
> + GOwnPtr<gchar> axOrientation;
> + if (checkElementState(m_element, ATK_STATE_HORIZONTAL))
> + axOrientation.set(g_strdup_printf("AXOrientation: AXHorizontalOrientation"));
> + else if (checkElementState(m_element, ATK_STATE_VERTICAL))
> + axOrientation.set(g_strdup_printf("AXOrientation: AXVerticalOrientation"));
> +
g_strdump_printf can just be g_strdump and even more simply can just be like this:
const char* axOrientation = 0;
if (checkElementState(m_element, ATK_STATE_HORIZONTAL))
axOrientation = "AXOrientation: AXHorizontalOrientation";
...
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list