[Webkit-unassigned] [Bug 111591] [EFL][WK2] Separate WebView further from EwkView

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=111591





--- Comment #27 from Caio Marcelo de Oliveira Filho <cmarcelo at webkit.org>  2013-03-18 07:11:03 PST ---
(From update of attachment 193535)
View in context: https://bugs.webkit.org/attachment.cgi?id=193535&action=review

I think we are converging to the right direction. :-)  Added a couple of comments on top of Kenneth comments. I think after this round we should get WK2 Owner to review again and land this.

>>> Source/WebKit2/UIProcess/API/C/efl/WKView.cpp:34
>>> +    RefPtr<WebView> webView = WebView::create(toImpl(contextRef), toImpl(pageGroupRef));
>> 
>> mm, no need to have RefPtr anymore.
> 
> on the other hand WKContextCreate.. functions use the same pattern, so can be leaved as it is I guess..

Yes. Leave WebView::create() returning RefPtr, because WKViewCreate should return a WKViewRef.

> Tools/TestWebKitAPI/PlatformWebView.h:54
> +typedef struct _Evas_Object Evas_Object;
>  typedef WKViewRef PlatformWKView;
> -typedef Ecore_Evas* PlatformWindow;
> +typedef Ecore_Evas* PlatformBacking;
> +typedef Evas_Object* PlatformWindow;

I don't think you should create another typedef here. If I recall correctly, Ecore_Evas* conceptually represents the PlatformWindow, and should keep that way.

You should either (1) make the Evas_Object* (of type ewk_*) be the PlatformWKView, (2) keep it as extra member, or (3) make a way to go from WKView -> ewk_type.

Given that you need Ewk for certain operations and for deletion, and there's no shared code that relies on PlatformWKView, I say you go for (1).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.