[Webkit-unassigned] [Bug 111591] [EFL][WK2] Separate WebView further from EwkView

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 18 05:46:37 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=111591





--- Comment #26 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2013-03-18 05:49:02 PST ---
(From update of attachment 193535)
View in context: https://bugs.webkit.org/attachment.cgi?id=193535&action=review

> Source/WebKit2/ChangeLog:10
> +
> +        EFL is not present in WKView API.
> +        WebView does not keep evas object.
> +

I would explain this better:

Main points being:
 - The WKView API has no dependency on EFL types
 - WebView does not store the Evas_Object

> Source/WebKit2/UIProcess/API/C/efl/WKView.h:81
> -
>  WK_EXPORT WKImageRef WKViewCreateSnapshot(WKViewRef);

We need to change this method (later) to not depend on EFL

> Source/WebKit2/UIProcess/API/efl/EwkView.cpp:273
> +    // Remove when possible.

FIXME:

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:92
> -Evas_Object* ewk_view_smart_add(Evas* canvas, Evas_Smart* smart, Ewk_Context* context, Ewk_Page_Group* pageGroup)
> +Evas_Object* ewkCreateEvasObject(WKContextRef context, WKPageGroupRef pageGroup, Evas* canvas, Evas_Smart* smart)

maybe just ewkCreate ? or ewkViewCreate(). Are these internal/private methods? then maybe just _ewk_create() or similar

> Source/WebKit2/UIProcess/API/efl/ewk_view_private.h:38
> +
> +EAPI Evas_Object* ewkCreateEvasObject(WKContextRef, WKPageGroupRef, Evas*, Evas_Smart*);
> +EAPI WKViewRef ewkGetWKView(Evas_Object*);
> +

Either we should use EFL naming or WK2 naming.

_ewk_view_create()
_ewk_view_wkview_get()

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list