[Webkit-unassigned] [Bug 112121] Keep a weak reference of decoded image in lazyDecodingPixelRef

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=112121





--- Comment #10 from KangYuan <kangyuan.shu at intel.com>  2013-03-18 03:06:42 PST ---
Thanks, i can ran test case now.

I realize the threading issue. So I add willRemoveFromCache() to ensure the image is immutable during locked by lazyDecodingPixelRef. Is that not enough? Maybe I miss some paths that reader-writer co-exists. I will double check, and also appreciate if someone point me how or where it can happen.

i think LazyDecodingPixelRef is generated for each image resources on the web page. It's the source bitmap for each drawImage (most times). We don't generate a new lazyDecodingPixelRef for each draw. Instead, we need to lock/unlock pixels for each draw, from the lazy-decoded image source.

Also, i fixed the crash for test cases and will upload again. I am ok to further discuss the solution. The patch is just my proposal...

Thanks for your comments.

-Kang Yuan

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.