[Webkit-unassigned] [Bug 112404] Web Inspector: DataGrid should reveal and select next/previous DataGridNode upon deletion of selected node

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Mar 17 22:33:11 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=112404





--- Comment #4 from Vivek Galatage <vivekg at webkit.org>  2013-03-17 22:35:37 PST ---
In my opinion, node selection change should happen inherently within the DataGrid whenever a node is removed. Making an explicit call to changeNodeAfterDeletion() from the call site (e.g. _deleteButtonClicked) shouldn't be necessary. 

Also when the DataGrid is used in multiple views with the inline deleting option, and if the call site doesn't invoke changeNodeAfterDeletion() explicitly, the DataGrid behavior would be inconsistent with respect to other views and this would hamper the User experience.

I would recommend that this method changeNodeAfterDeletion() be moved in the DataGridNode and make it a private API with more meaningful naming such as ( _nodeSelectionChanged() ) and should be invoked from WebInspector.DataGridNode.removeChild() implicitly.

@vsevik, I would be glad to have your views on the above comment.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list