[Webkit-unassigned] [Bug 112450] New: Clean up RenderFrameSet::nodeAtPoint

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=112450

           Summary: Clean up RenderFrameSet::nodeAtPoint
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Event Handling
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: allan.jensen at digia.com


As part of my work to remove side-effects in hit-testing I want to also eliminate any tests on the HitTestRequest::isReadOnly(), only one such remain and is in a cryptic test in RenderFrameSet::nodeAtPoint.

if (inside && frameSet()->noResize()
            && !request.readOnly() && !result.innerNode() && !request.touchMove())

Reseaching the history of the test shows that it has been invalid since r18333 in December 2006 where a part of the test was accidentally reversed from !element()->noResize to frameSet->noResize(). That has however had no effect since the check itself was dead code since r17770 in November 2006 where the newly introduced EventHandler started taking care of sending events the frameset being resized without needing a hit-test.

The check can therefore be removed and RenderFrameSet::nodeAtPoint made both cleaner and sane.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.