[Webkit-unassigned] [Bug 111688] Web Inspector: Details of InjectedScript function call shall not be linkified in Timeline panel.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=111688


Vsevolod Vlasov <vsevik at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #192854|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #11 from Vsevolod Vlasov <vsevik at chromium.org>  2013-03-15 01:34:51 PST ---
(From update of attachment 192854)
View in context: https://bugs.webkit.org/attachment.cgi?id=192854&action=review

> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:1132
> +            this._validScriptLocation = this.scriptName ? !!this.scriptName.asParsedURL() : false;

I think it's possible that a script with the name that could not be correctly parsed can still be correctly linkified (think sourceURL).
Such false negative would be a much worse issue than current false positive behavior.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.