[Webkit-unassigned] [Bug 112411] WebKitCSSKeyframesRule.idl should have item method

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=112411


Kentaro Hara <haraken at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #193243|review?                     |review-
               Flag|                            |




--- Comment #3 from Kentaro Hara <haraken at chromium.org>  2013-03-15 00:03:57 PST ---
(From update of attachment 193243)
View in context: https://bugs.webkit.org/attachment.cgi?id=193243&action=review

> Source/WebCore/ChangeLog:10
> +        There is WebKitCSSKeyframesRule::item() method but WebKitCSSKeyframesRule.idl doesn't have item method.
> +        Currently CodeGeneratorV8 have to treat WebKitCSSKeyframesRule specially due to lack of item() definition.
> +        (On the other hand it seems that JSC generator doesn't need to get IndexGetter's return type from IDL.)

What is the spec saying? We should follow the spec.

> Source/WebCore/ChangeLog:12
> +        No new tests, refactoring only. No run-bindings-tests changes.

This is not refactoring. You're changing behavior that is exposed to outside. You have to add layout tests. (But before that I'd like to confirm what the spec is saying.)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.