[Webkit-unassigned] [Bug 112275] TextIterator emits LF for a br element inside an empty input element

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=112275





--- Comment #20 from Ryosuke Niwa <rniwa at webkit.org>  2013-03-14 20:09:20 PST ---
(From update of attachment 193224)
View in context: https://bugs.webkit.org/attachment.cgi?id=193224&action=review

> Source/WebCore/editing/TextIterator.cpp:754
> +    bool nodeIsInsideInputElement = node->isInShadowTree() && node->shadowHost()->toInputElement();

It seems not ideal that we check this condition first because the vast majority of tests aren't br.
Given that it's probably better to check br'ness first as in:
if ((!renderer || !renderer->isBR()) && !node->hasTagName(brTag))
    return false;
return emitsOriginalText || !(node->isInShadowTree() && node->shadowHost()->toInputElement());

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.