[Webkit-unassigned] [Bug 91554] viewport units (vw, vh) don't work in CSS transforms

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91554





--- Comment #13 from Timothy Loh <timloh at chromium.org>  2013-03-13 17:03:59 PST ---
(In reply to comment #12)
> This patch looks good to me. I think it'd be good to break it up into a couple smaller pieces, but they don't need to be tiny given then mechanical nature of this patch. So, ideally you'd do something like the following set of patches to make it easier for the reviewer to verify correctness:
> 
> 1. Add the valueForLength methods to RenderObject.h and change all the callers in the rendering code to use these new methods that don't require passing in the RenderView (exactly as you have in your current patch).
> 2. Change the Length.h versions of all these functions to take an optional viewport size instead of a RenderView.
> 3. Change the viewport size argument to be required and add tests.
> 
> The first two won't change any behavior and just need to pass the existing tests. 
> 
> That sound ok?

Sounds fine. I think there were a few places in getting calc working with viewport units which required some slight non-mechanical changes, so I might put that as a separate patch between your suggested steps 2 and 3.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.