[Webkit-unassigned] [Bug 109404] Add selectTrailingWhitespaceEnabled setting to WebCore::Page

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=109404





--- Comment #53 from Manuel Rego Casasnovas <rego at igalia.com>  2013-03-13 15:26:28 PST ---
(In reply to comment #52)
> (From update of attachment 192999 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=192999&action=review
> 
> r=me provided the following comments are addressed.
> 
> > Source/WebKit/mac/WebView/WebView.mm:789
> > +        _private->page->settings()->setSmartInsertDeleteEnabled(smartInsertDeleteEnabled);
> > +        _private->page->settings()->setSelectTrailingWhitespaceEnabled(!smartInsertDeleteEnabled);
> 
> Why don't we call [self setSelectTrailingWhitespaceEnabled] here.

I guess that as the key is called "WebSmartInsertDeleteEnabled" it's clearer if we use setSmartInsertDeleteEnabled:
    if ([[NSUserDefaults standardUserDefaults] objectForKey:WebSmartInsertDeleteEnabled])                
        [self setSmartInsertDeleteEnabled:[[NSUserDefaults standardUserDefaults] boolForKey:WebSmartInsertDeleteEnabled]];

> > Source/WebKit/mac/WebView/WebView.mm:2481
> > +        // Set smartInsertDeleteEnabled as they are mutually exclusive.
> 
> I don't think this and similar comments are useful as the code clearly indicates they're mutually exclusive already. Please remove them.

Yep. I'll provide a new patch with this 2 changes. Thanks for the review.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.