[Webkit-unassigned] [Bug 109404] Add selectTrailingWhitespaceEnabled setting to WebCore::Page

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=109404


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #192999|review?                     |review+
               Flag|                            |




--- Comment #52 from Ryosuke Niwa <rniwa at webkit.org>  2013-03-13 15:04:29 PST ---
(From update of attachment 192999)
View in context: https://bugs.webkit.org/attachment.cgi?id=192999&action=review

r=me provided the following comments are addressed.

> Source/WebKit/mac/WebView/WebView.mm:789
> +        _private->page->settings()->setSmartInsertDeleteEnabled(smartInsertDeleteEnabled);
> +        _private->page->settings()->setSelectTrailingWhitespaceEnabled(!smartInsertDeleteEnabled);

Why don't we call [self setSelectTrailingWhitespaceEnabled] here.

> Source/WebKit/mac/WebView/WebView.mm:2481
> +        // Set smartInsertDeleteEnabled as they are mutually exclusive.

I don't think this and similar comments are useful as the code clearly indicates they're mutually exclusive already. Please remove them.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.