[Webkit-unassigned] [Bug 112276] Allow multiple searchKeys to be passed to AXUIElementCopyParameterizedAttributeValue

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=112276


chris fleizach <cfleizach at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #192964|                            |review-
               Flag|                            |




--- Comment #4 from chris fleizach <cfleizach at apple.com>  2013-03-13 12:57:30 PST ---
(From update of attachment 192964)
View in context: https://bugs.webkit.org/attachment.cgi?id=192964&action=review

> Source/WebCore/accessibility/AccessibilityObject.cpp:121
> +    unsigned length = criteria->searchKeys->size();

my guess is that size() is a size_t object

> Source/WebCore/accessibility/AccessibilityObject.cpp:124
> +        switch (criteria->searchKeys->at(i)) {

all these changes here are unnecessary and they'll fail the style guidelines

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:3187
> +        if ([searchKeyEntry isKindOfClass:[NSString self]])

[NSString class]

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:3189
> +        else if ([searchKeyEntry isKindOfClass:[NSArray self]]) {

[NSArray class]

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:3190
> +            unsigned length = [(NSArray *)searchKeyEntry count];

i believe count is a NSUInteger

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:3192
> +            for (unsigned i = 0; i < length; ++i) {

size length is NSUInteger, so should i

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:3194
> +                if ([searchKey isKindOfClass:[NSString self]])

[NSString class]

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.