[Webkit-unassigned] [Bug 110524] Add a way to watch pages for elements matching a CSS selector

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=110524





--- Comment #11 from Jeffrey Yasskin <jyasskin at chromium.org>  2013-03-12 19:21:04 PST ---
(From update of attachment 192328)
View in context: https://bugs.webkit.org/attachment.cgi?id=192328&action=review

>> Source/WebCore/dom/Document.h:1176
>> +    void removeSelectorMatch(String selector);
> 
> Nit: const String& to avoid some refcount churn.

Done

>> Source/WebCore/rendering/style/RenderStyle.h:1266
>> +    void removeCallbackSelector(String selector);
> 
> Nit: const String&

Done

>> Source/WebKit/chromium/tests/WebFrameTest.cpp:298
>> +    doc.insertUserStyleSheet("span{-webkit-callback:-webkit-presence !important}",
> 
> Is !important necessary in this test case?

In this one it's not necessary, although it reflects what I think will be the common use case. I've removed it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.