[Webkit-unassigned] [Bug 98270] [GTK][WK2] Add API to retrieve a snapshot from a webview
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Mar 12 01:19:48 PDT 2013
https://bugs.webkit.org/show_bug.cgi?id=98270
--- Comment #45 from Carlos Garcia Campos <cgarcia at igalia.com> 2013-03-12 01:22:12 PST ---
(From update of attachment 192271)
View in context: https://bugs.webkit.org/attachment.cgi?id=192271&action=review
I've a few more really minor comments that could be improved before landing
> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:2988
> + **/
Nit: don't use double * here, it's only needed to start the comment block. This doesn't really matter, but it's consistent with all other api docs comments.
> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:3018
> + **/
Ditto.
> Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitWebExtension.cpp:23
> +#include "FrameView.h"
Use #include <WebCore/Foo.h> to include webcore headers.
> Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitWebExtension.cpp:99
> + SnapshotOptions snapshotOptions = static_cast<SnapshotOptions>(static_cast<WebUInt64*>(message.get(String::fromUTF8("SnapshotOptions")))->value());
You removed all the fromUTF8 except this one String::fromUTF8("SnapshotOptions").
> Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitWebExtension.cpp:149
> + ASSERT(WKGetTypeID(messageBody) == WKDictionaryGetTypeID());
> + webkitWebExtensionDidReceiveMessageToPage(WEBKIT_WEB_EXTENSION(clientInfo), toImpl(page), toImpl(name)->string(), *toImpl(static_cast<WKDictionaryRef>(messageBody)));
Since these are messages to pages, they should be handled by WebKitWebPage. Add webkitWebPageDidReceiveMessage instead of webkitWebExtensionDidReceiveMessageToPage, and move the code there.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list